Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mocktikv: split rpcHandler to kvHandler and coprHandler #22857

Merged
merged 6 commits into from
Mar 26, 2021
Merged

mocktikv: split rpcHandler to kvHandler and coprHandler #22857

merged 6 commits into from
Mar 26, 2021

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Feb 21, 2021 •
edited
Loading

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

mockstore should be inside store/tikv.
Part of #22513

What is changed and how it works?

What's Changed:

  • extract Session and split the rpcHandler into kvHandler and coprHandler. Later we can move kvHandler part into store/tikv.

Check List

Tests

  • Unit test

Release note

  • No release note

@disksing disksing requested a review from a team as a code owner February 21, 2021 05:17
@disksing disksing requested review from lzmhhh123 and removed request for a team February 21, 2021 05:17
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Feb 21, 2021
@disksing disksing marked this pull request as draft February 22, 2021 02:36
@disksing
Copy link
Contributor Author

/run-all-tests

1 similar comment
@disksing
Copy link
Contributor Author

/run-all-tests

@disksing disksing marked this pull request as ready for review February 22, 2021 03:12
@disksing
Copy link
Contributor Author

/run-all-tests

@disksing
Copy link
Contributor Author

/run-tics-test

@disksing disksing marked this pull request as draft February 22, 2021 03:46
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/infra labels Feb 22, 2021
@disksing
mocktikv: split rpcHandler to kvHandler and coprHandler
b14fde5 
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 4, 2021
@disksing disksing changed the title store: move mockstore/mocktikv to tikv/mockstore/mocktikv mocktikv: split rpcHandler to kvHandler and coprHandler Mar 4, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2021
@disksing disksing marked this pull request as ready for review March 4, 2021 10:14
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2021
@disksing
Copy link
Contributor Author

disksing commented Mar 4, 2021

/run-all-tests

AndreMouche
AndreMouche approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@AndreMouche: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • andylokandy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2021
@AndreMouche
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 154070b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2021
@AndreMouche
Copy link
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Member

@disksing: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7a35af8 into pingcap:master Mar 26, 2021
@disksing disksing deleted the mocktikv branch April 17, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@andylokandy andylokandy andylokandy approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
component/store sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disksing @ti-chi-bot @AndreMouche @andylokandy